✅ Deploy Preview for actualbudget ready!

Name	Link
🔨 Latest commit	6c08db7
🔍 Latest deploy log	https://app.netlify.com/sites/actualbudget/deploys/663cf49ef460b5000830dcc3
😎 Deploy Preview	https://deploy-preview-2731.demo.actualbudget.org
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Bundle Stats — desktop-client

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Bundle Stats — loot-core

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Changeset

No files were changed

We generally try to avoid having extra settings like this. Thats partly why the discussion has so heated around this topic. Its either one way or another, or we have to add an extra setting. Undesirable no matter how we shake it.

A thought I had just now. Having settings be contextual is nicer than global settings. Could we put this setting inside the autocomplete somehow instead of the settings page?

Another thought. Could we have a way to tell the autocomplete to include groups incidentally? Like type "$bills" to search for the group bills? That is still getting to magic syntax which is its own kind of non-optimal

@youngcw I agree that having a setting like that is not optimal.

I'm not sure on how to add the setting in the dropdown in a nice and unobtrusive way. Adding it at the bottom of the dropdown would not be great: once set to the user preference, it will be rather useless and keep displaying all the time.

I can add a magic syntax instead, but its discoverability will be rather poor, and it will not feel really natural (especially on mobile)

I can also move the new setting in the "advanced settings", would it be better?

thats a good point that mobile would probably be a pain with magic syntax

@youngcw I moved the new setting in the "advanced settings" sections. I feel it's the best that can be done to support the two ways of using the category autocomplete.

We've been back-and-forth with this for a while now and the current consensus is that category groups should not be included in search results.

We also do not want to have a setting for each and every little UI quirk as it would unnecessarily clutter the product. Instead - we have opinionated workflows.

I can see two options how to proceed here:

1. add this functionality in your fork - you'll have totally freedom and flexibility there; and then you can continuously sync the upstream changes in your fork to get the latest updates
2. figure out another way how to enable this functionality (without creating a separate setting for it) - @youngcw proposal is interesting, but as pointed out before - would not work for mobile; so a good starting point here would be to write a proposal in the linked feature ticket and get a consensus there before jumping to implementation.

edit: personally - I don't care about including/excluding category groups here. What I do care about is the consistency in the product. We can't add a feature, then remove it, then add it, then again remove it.

@MatissJanis Ok, duly noted then.

A few points before leaving:

• The feature issue [Feature] Search by Category Including Subcategory #2324 explicitly list a config toggle as a solution. You took the time to answer there, you could have stated then that it was not acceptable.
• The consensus is rather shaky IMHO, 8 persons, including a maintainer, voted for the reversal outlined in [Feature] Search by Category Including Subcategory #2324. And it was also asked in [Bug]: Category search no longer finds groups #1767.
• Consistency of the product is well and good, but we are not yet in a loop of endlessly adding/removing the same change. Unless you meant that nothing should be ever reversed in the product.